[Buildroot] [PATCH 3/3] ljsyscall: refactor with BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS

François Perrad fperrad at gmail.com
Wed Mar 18 12:26:11 UTC 2015


2015-03-17 23:37 GMT+01:00 Angelo Compagnucci <angelo.compagnucci at gmail.com>
:

> Dear Francois Perrad,
>
>
> 2015-03-17 22:45 GMT+01:00 Angelo Compagnucci <
> angelo.compagnucci at gmail.com>:
> > Dear Francois Perrad,
> >
> > 2015-03-17 21:04 GMT+01:00 Francois Perrad <fperrad at gmail.com>:
> >
> > Reviewed-by: Angelo Compagnucci <angelo.compagnucci at gmail.com>
> >> Signed-off-by: Francois Perrad <francois.perrad at gadz.org>
> >> ---
> >
> > Patch is fine for me. Nothing to add.
> >
> >>  package/ljsyscall/Config.in | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/package/ljsyscall/Config.in b/package/ljsyscall/Config.in
> >> index dcbd521..b9ff04d 100644
> >> --- a/package/ljsyscall/Config.in
> >> +++ b/package/ljsyscall/Config.in
> >> @@ -3,12 +3,12 @@ config BR2_PACKAGE_LJSYSCALL
> >>         # ljsyscall is specifically for LuaJIT, not Lua.
> >>         depends on BR2_PACKAGE_LUAJIT
> >>         # ljsyscall is only available for some target architectures
> >> -       depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm ||
> BR2_armeb
> >> +       depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
>
> Sorry for not having spotted before but
>
> BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS != BR2_i386 || BR2_x86_64 ||
> BR2_powerpc || BR2_arm || BR2_armeb
>
> Actually, BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS is BR2_i386 has this condition
> more
>
> ((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT)
>
> Are you sure LJSYSCALL package works on mips?
>

there is a folder
http://github.com/justincormack/ljsyscall/tree/master/syscall/linux/mips
and the readme (section requirements) contains :
      " On Linux ARM (soft or hard float), x86, AMD64, and PPC32 and MIPS32
(o32 ABI) architectures are supported; this is the complete set of
architectures that LuaJIT supports. "

François


> >>         help
> >>           An FFI implementation of the Linux and NetBSD kernel ABIs for
> LuaJIT.
> >>
> >>           http://github.com/justincormack/ljsyscall
> >>
> >>  comment "ljsyscall needs LuaJIT"
> >> -       depends on !BR2_PACKAGE_LUAJIT && (BR2_i386 || BR2_x86_64 ||
> BR2_powerpc || BR2_arm || BR2_armeb)
> >> +       depends on !BR2_PACKAGE_LUAJIT &&
> !BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
> >>
> >> --
> >> 2.1.0
> >>
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot at busybox.net
> >> http://lists.busybox.net/mailman/listinfo/buildroot
> >
> >
> >
> > --
> > Profile: http://it.linkedin.com/in/compagnucciangelo
>
>
>
> --
> Profile: http://it.linkedin.com/in/compagnucciangelo
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150318/b229e3a4/attachment.html>


More information about the buildroot mailing list