[Buildroot] [PATCH v3 1/1] package/softether: Fix iconv-related compile error

Bernd Kuhls bernd.kuhls at t-online.de
Sun Mar 15 08:29:19 UTC 2015


Fixes
http://autobuild.buildroot.net/results/72e/72eab3a6f162e3c5eac380f88b54d4f314d52445/
http://autobuild.buildroot.net/results/f47/f473882cd35445cbe5b3b15635d555340183951a/
http://autobuild.buildroot.net/results/45b/45b54b59935c3994c526593836ad433b82148f12/
http://autobuild.buildroot.net/results/1e4/1e4af4642691ea9681b39eb1ce4f8107e8c3ff5f/
http://autobuild.buildroot.net/results/182/182e658723d654d45c683dc2bc0b959c82c37826/
http://autobuild.buildroot.net/results/446/4467fd6aad86bf176625fdc74f5802f35519f157/
http://autobuild.buildroot.net/results/4a2/4a2cafabe048c5255b21cf25f149542561f60935/
http://autobuild.buildroot.net/results/12a/12a9de3d946b1379ed8bc772e556f163af758e6b/
http://autobuild.buildroot.net/results/795/795b02b656e3a6f265a5182140f4be62cf22ae7f/

To reproduce the build error I used this defconfig

BR2_arm=y
BR2_arm1176jzf_s=y
BR2_COMPILER_PARANOID_UNSAFE_PATH=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/armv6-ctng-linux-uclibcgnueabi.tar.xz"
BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="armv6-ctng-linux-uclibcgnueabi"
BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_9=y
BR2_TOOLCHAIN_EXTERNAL_LARGEFILE=y
BR2_TOOLCHAIN_EXTERNAL_WCHAR=y
BR2_TOOLCHAIN_EXTERNAL_HAS_SSP=y
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_PACKAGE_SOFTETHER=y

Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
---
v3: The real problem seemed to be LIBS+= (Peter)
v2: Simplify libiconv check (Thomas)

 package/softether/softether.mk |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/package/softether/softether.mk b/package/softether/softether.mk
index 8f8734d..1c219b8 100644
--- a/package/softether/softether.mk
+++ b/package/softether/softether.mk
@@ -16,12 +16,12 @@ SOFTETHER_AUTORECONF = YES
 
 ifeq ($(BR2_ENABLE_LOCALE),)
 SOFTETHER_DEPENDENCIES += libiconv
-SOFTETHER_CONF_ENV = LIBS+=" -liconv"
+SOFTETHER_LIBS += -liconv
 endif
 
 ifeq ($(BR2_STATIC_LIBS),y)
 # openssl needs zlib
-SOFTETHER_CONF_ENV += LIBS+=" -lz"
+SOFTETHER_LIBS += -lz
 endif
 
 SOFTETHER_CONF_OPTS = \
@@ -31,7 +31,9 @@ SOFTETHER_CONF_OPTS = \
 # softether uses clock_gettime but forgets to link against -lrt
 # breaking the build against older libc's that don't provide this
 # symbol in libc
-SOFTETHER_CONF_ENV += LIBS+=" -lrt"
+SOFTETHER_LIBS += -lrt
+
+SOFTETHER_CONF_ENV += LIBS="$(SOFTETHER_LIBS)"
 HOST_SOFTETHER_CONF_ENV += LIBS+=" -lrt"
 
 # host-libiconv does not exist, therefore we need this extra line
-- 
1.7.10.4



More information about the buildroot mailing list