[Buildroot] [PATCH 1/1] bash: added option to disable locale support

[Matthew Weber]

Thomas, all.

On Mon, Mar 9, 2015 at 4:42 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Matt Weber,
>
> On Mon,  9 Mar 2015 16:13:15 -0500, Matt Weber wrote:
>
>> +if BR2_PACKAGE_BASH
>> +
>> +config BR2_PACKAGE_BASH_NO_LOCALE
>> +     bool "disable locale support"
>> +     help
>> +       Disable locale support for cases where toolchain has it
>> +       but target isn't setup to use it.
>> +
>> +endif
>
> To be honest, I'm not sure we want to support such cases. What does it
> mean for the target to not be setup to use locales?

I should probably clarify, this disabled the runtime check of locale
that bash did everytime a shell was invoked.  All packages where still
built with locale support.  Busybox ash didn't perform this check so
we never noticed it until we switched to bash.  (I believe, will have
to double check)Bash is running  setlocale after checking for a env
variable LC_xxxxx before the shell starts.  Currently we don't have
our env setup to by default have LC_xxxxx set.  Instead we  set the
LC_xxxxx as part of the service/app start rcS script. (There maybe
better way's of handling this I'm sure).

Thanks,
Matt

>
> What is the opinion of other Buildroot developers?
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com