[Buildroot] [PATCH 1/1] Fix barebox compilation issue with 64bit kernel
Fabien Lahoudere
fabienlahoudere.pro at gmail.com
Tue Mar 3 14:25:24 UTC 2015
Hello
Thank you for the correction.
I will rework my patch but I have questions:
- If I change the title, and submit a new patch, what happened to the
old one in the patchwork?
- Is it necessary to prefix the new title with "PATCH v2"?
Fabien
Le 03/03/2015 14:31, Thomas Petazzoni a écrit :
> Dear Lahoudere Fabien,
>
> On Tue, 3 Mar 2015 13:27:53 +0100, Lahoudere Fabien wrote:
>> Signed-off-by: Lahoudere Fabien <fabienlahoudere.pro at gmail.com>
> This should normally be:
>
> Signed-off-by: <first name> <last name> <email>
>
>> ---
>> boot/barebox/barebox.mk | 2 ++
>> 1 file changed, 2 insertions(+)
> This looks good but the commit log could be improved:
>
> barebox: fix compilation on x86-64 architecture
>
> Barebox uses KERNEL_ARCH to derive BAREBOX_ARCH, but doesn't
> currently handle the case of the x86-64 architecture. In this
> case KERNEL_ARCH is x86_64, but BAREBOX_ARCH should be x86
> nonetheless.
>
> The commit title should almost always look like:
>
> <pkg>: <description>
>
> Thanks,
>
> Thomas
More information about the buildroot
mailing list