[Buildroot] [PATCH 2/4] core/pkg-kconfig: move the kconfig fixups to a macro

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Jun 12 21:33:50 UTC 2015


Dear Yann E. MORIN,

On Sat,  6 Jun 2015 13:54:24 +0200, Yann E. MORIN wrote:

>  # In order to get a usable, consistent configuration, some fixup may be needed.
>  # The exact rules are specified by the package .mk file.
> -$$($(2)_DIR)/.stamp_kconfig_fixup_done: $$($(2)_DIR)/.config
> +define $(1)_FIXUP_KCONFIG
>  	$$($(2)_KCONFIG_FIXUP_CMDS)
>  	@yes "" | $$($(2)_MAKE_ENV) $$(MAKE) -C $$($(2)_DIR) \

We could use $(@D) instead of $$($(2)_DIR) here.

>  		$$($(2)_KCONFIG_OPTS) oldconfig
> -	$$(Q)touch $$@
> +	$$(Q)touch $$($(2)_DIR)/.stamp_kconfig_fixup_done

and here. But that's indeed not very important, since they are the same.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list