[Buildroot] [PATCH 1/2] benejson: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jan 25 18:59:01 UTC 2015


Dear Yann E. MORIN,

On Sun, 25 Jan 2015 18:57:42 +0100, Yann E. MORIN wrote:
> From: David Bender <codehero at yahoo.com>
> 
> Added C/C++ JSON parsing package benejson.
> 
> Signed-off-by: Dave Bender <bender at benegon.com>
> Signed-off-by: David Bender <codehero at gmail.com>
> [yann.morin.1998 at free.fr: fix static/shared install; enhance help entry;
>  fix extra space; add hash]
> Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>

Thanks, applied after doing minor changes (see below).

> +BENEJSON_VERSION = 0.9.7
> +BENEJSON_SITE = $(call github,codehero,benejson,$(BENEJSON_VERSION))
> +BENEJSON_LICENSE = MIT
> +BENEJSON_LICENSE_FILES = LICENSE
> +BENEJSON_INSTALL_STAGING = YES
> +
> +BENEJSON_DEPENDENCIES = host-scons
> +
> +BENEJSON_SCONS_ENV = $(TARGET_CONFIGURE_OPTS) CROSS=$(TARGET_CROSS)

This variable is only used once, so I just removed its definition, and
used its value where it was used.

> +
> +define BENEJSON_BUILD_CMDS
> +	(cd $(@D); \
> +	 $(BENEJSON_SCONS_ENV) \
> +	 $(SCONS) \
> +	 $(BENEJSON_SCONS_OPTS) \

Indentation of one tab + one space is a bit weird, so I changed that to
two tabs. I also removed the reference to BENEJSON_SCONS_OPTS since
this variable was never defined.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list