[Buildroot] [PATCH v3 5/7] dtc: add host build

[Peter Seiderer]

Hello Yann,

> Gesendet: Sonntag, 18. Januar 2015 um 17:51 Uhr
> Von: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> An: "Peter Seiderer" <ps.report at gmx.net>
> Cc: buildroot at busybox.net, "Fabio Porcedda" <fabio.porcedda at gmail.com>, "Jeremy Kerr" <jk at ozlabs.org>, "Thomas Petazzoni" <thomas.petazzoni at free-electrons.com>, "Matthew Weber" <matthew.weber at rockwellcollins.com>
> Betreff: Re: [PATCH v3 5/7] dtc: add host build
>
> Peter, All,
> 
> On 2015-01-13 20:40 +0100, Peter Seiderer spake thusly:
> > Signed-off-by: Peter Seiderer <ps.report at gmx.net>
> [--SNIP--]
> > diff --git a/package/dtc/dtc.mk b/package/dtc/dtc.mk
> > index c01fe7b..b0e2f28 100644
> > --- a/package/dtc/dtc.mk
> > +++ b/package/dtc/dtc.mk
> > @@ -43,4 +43,14 @@ define DTC_INSTALL_TARGET_CMDS
> >  	$(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) PREFIX=/usr $(DTC_INSTALL_GOAL)
> >  endef
> >  
> > +# host build
> > +define HOST_DTC_BUILD_CMDS
> > +	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) PREFIX=/usr
> 
> This is a host tool, you should set PREFIX=$(HOST_DIR)/usr  ...
> 

O.k. (was copy/paste from the target build command), will fix on next
patch iteration...

> > +endef
> > +
> > +define HOST_DTC_INSTALL_CMDS
> > +	$(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) PREFIX=/usr install-bin
> 
> ... ditto, and not set a DESTDIR.
>

O.k, will fix, thanks for review...

Regards,
Peter
 
> Regards,
> Yann E. MORIN.
> 
> > +endef
> > +
> >  $(eval $(generic-package))
> > +$(eval $(host-generic-package))
> > -- 
> > 2.1.2
> > 
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
>