[Buildroot] [PATCH 4/7] rsyslog: clean up sysv initscript

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Jan 14 19:31:12 UTC 2015


Dear Gustavo Zacarias,

On Tue, 13 Jan 2015 20:16:59 -0300, Gustavo Zacarias wrote:

>  start() {
> -	echo -n "Starting rsyslog daemon: "
> -	umask 077
> -	start-stop-daemon -S -q -p /var/run/rsyslogd.pid --exec /usr/sbin/rsyslogd
> -	echo "OK"
> +  echo -n "Starting rsyslog daemon: "
> +  umask 077

Do we really need this umask 077 ?

>  restart() {
> -	stop
> -	start
> +  stop
> +  sleep 1

And this sleep 1 ?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list