[Buildroot] [PATCH 3/7] rsyslog: rename sysv initscript to S01logging

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Jan 14 19:30:51 UTC 2015


Dear Gustavo Zacarias,

On Tue, 13 Jan 2015 20:16:58 -0300, Gustavo Zacarias wrote:
> Do it to avoid having duplicate and conflicting functionality with
> busybox's S01logging.
> 
> Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
> ---
>  package/rsyslog/{S01rsyslog => S01logging} | 0
>  package/rsyslog/rsyslog.mk                 | 4 ++--
>  2 files changed, 2 insertions(+), 2 deletions(-)
>  rename package/rsyslog/{S01rsyslog => S01logging} (100%)

To be honest, I wasn't really sure whether the right approach to handle
this issue was to rename the init script as you did, or to have rsyslog
explicitly remove S01logging when Busybox is enabled.

Since the rest of patch series was doing some cleanup on the renamed
S01logging, I decided to take your approach, but I must say I wasn't
entirely sure on how to handle this.

Comments from others are welcome, I don't consider the proposed
solution to be set in stone.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list