[Buildroot] [PATCH v2 1/4] dtc: fix project and download url

Peter Seiderer ps.report at gmx.net
Mon Jan 12 22:15:30 UTC 2015


Hello Thomas,

> Gesendet: Montag, 12. Januar 2015 um 21:39 Uhr
> Von: "Thomas Petazzoni" <thomas.petazzoni at free-electrons.com>
> An: "Peter Seiderer" <ps.report at gmx.net>
> Cc: buildroot at busybox.net
> Betreff: Re: [Buildroot] [PATCH v2 1/4] dtc: fix project and download url
>
> Dear Peter Seiderer,
> 
> On Sun, 11 Jan 2015 19:16:03 +0100, Peter Seiderer wrote:
> > and rename patches to new convention
> > 
> > Signed-off-by: Peter Seiderer <ps.report at gmx.net>
> > ---
> >  package/dtc/0001-separate-lib-install.patch | 28 +++++++++++++++++++++++++
> >  package/dtc/0002-extra-cflags.patch         | 32 +++++++++++++++++++++++++++++
> >  package/dtc/Config.in                       |  2 +-
> >  package/dtc/dtc-extra_cflags.patch          | 32 -----------------------------
> >  package/dtc/dtc-separate-lib-install.patch  | 28 -------------------------
> >  package/dtc/dtc.mk                          |  5 +++--
> >  6 files changed, 64 insertions(+), 63 deletions(-)
> >  create mode 100644 package/dtc/0001-separate-lib-install.patch
> >  create mode 100644 package/dtc/0002-extra-cflags.patch
> >  delete mode 100644 package/dtc/dtc-extra_cflags.patch
> >  delete mode 100644 package/dtc/dtc-separate-lib-install.patch
> 
> Thanks. I was going to apply this, but since PATCH 2 has some issues,
> I'll give some minor comments on this one as well:
> 
>  1/ You're doing two separate things here: change the project URL, and
>     rename the patches. So this should be done in two separate patches.
> 

O.k.

>  2/ Please enable rename detection in Git, so we can clearly see in the
>     patch that it's a rename.
>

O.k.
 
> Can you resend with this fixed?
>

Will do....

Regards,
Peter
 
> Thanks!
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> 


More information about the buildroot mailing list