[Buildroot] [PATCH] janus-gateway: add a patch to use -Wunused-but-set-variable only when available

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Jan 5 20:09:11 UTC 2015


Dear Yann E. MORIN,

On Sun, 4 Jan 2015 18:41:02 +0100, Yann E. MORIN wrote:

> Granted, for us Buildroot, that has virtually zero-impact, because the
> expanded code would be about the same you wrote. But if we want to
> upstream anything, better be using the state-of-the-art solution. ;-)
> 
> But anyway, why don't you simply write:
> 
>     AX_CHECK_COMPILE_FLAG([-Wunused-but-set-variable],
>         [GCC_WARN_UNUSED_BUT_SET=-Wunused-but-set-variable])
>     AC_SUBST([GCC_WARN_UNUSED_BUT_SET])
> 
> Also, as discused on IRC: add a comment in the .mk stating that
> AUTORECONF is needed because we also touch the autostuff.

Thanks for your comments. I adjusted my patch according to your
comments and applied it.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list