[Buildroot] [PATCH] support/download: further silence the git helper

Fabio Porcedda fabio.porcedda at gmail.com
Mon Jan 5 11:35:47 UTC 2015


On Sun, Jan 4, 2015 at 7:10 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> We expresely call printf in the git helper, calls which were not
> addresed in the previous silent-build patchset.
>
> Just redirect stdout to oblivion when being silent.
>
> Reported-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> ---
>  support/download/git | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/download/git b/support/download/git
> index 7f1801f..73cbc0f 100755
> --- a/support/download/git
> +++ b/support/download/git
> @@ -14,7 +14,7 @@ set -e
>  verbose=-v
>  while getopts :q OPT; do
>      case "${OPT}" in
> -    q)  verbose=-q;;
> +    q)  verbose=-q; exec >/dev/null;;

As general rule It's best to use "&&" instead of ";" so any error can
be caught, otherwise is:
Acked-by: Fabio Porcedda <fabio.porcedda at gmail.com>
Tested-by: Fabio Porcedda <fabio.porcedda at gmail.com>

BR
-- 
Fabio Porcedda


More information about the buildroot mailing list