[Buildroot] [PATCH v7 1/4] Makefile: improve detection of make "-s" flag
Yann E. MORIN
yann.morin.1998 at free.fr
Thu Jan 1 16:03:25 UTC 2015
Fabio, All,
On 2014-12-30 14:58 +0100, Fabio Porcedda spake thusly:
> Because it's just checked the presence of the "s" character even a
> make --warn-undefined-variables
> is detected as a silent build so fix this by filtering out long options.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda at gmail.com>
> Cc: Arnout Vandecappelle <arnout at mind.be>
Acked-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Regards,
Yann E. MORIN.
> ---
>
> Notes:
> v6:
> - use QUIET instead of BR_QUIET
> v5:
> - remove spaces after commas (Yann)
> v4:
> - split this patch from the patch set to send to muster as bugfix
> v2:
> - remove spurious space at the beginning of the QUIET variable (Arnout)
> v4:
> - split this patch from the patch set to send to muster as bugfix
> v2:
> - remove spurious space at the beginning of the QUIET variable (Arnout)
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index e18a87e..c033620 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -303,7 +303,7 @@ GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
> TARGETS :=
>
> # silent mode requested?
> -QUIET := $(if $(findstring s,$(MAKEFLAGS)),-q)
> +QUIET := $(if $(findstring s,$(filter-out --%,$(MAKEFLAGS))),-q)
>
> # Strip off the annoying quoting
> ARCH := $(call qstrip,$(BR2_ARCH))
> --
> 2.1.0
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list