[Buildroot] [PATCH v2 1/2] libsigrok: enable building C++ bindings

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Feb 23 17:18:21 UTC 2015


Dear Bartosz Golaszewski,

On Mon, 23 Feb 2015 12:32:48 +0100, Bartosz Golaszewski wrote:

> +config BR2_PACKAGE_LIBSIGROKCXX
> +	bool "build C++ bindings"
> +	select BR2_PACKAGE_GLIBMM
> +	depends on BR2_PACKAGE_LIBSIGROK
> +	depends on BR2_TOOLCHAIN_BUILDROOT_CXX

This should have been BR2_INSTALL_LIBSTDCPP, otherwise your code only
works for internal toolchains, not external toolchains.

> +	help
> +	  Build libsigrok C++ bindings as well.
> +
>  comment "libsigrok needs a toolchain w/ wchar, threads"
>  	depends on BR2_USE_MMU
>  	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> +
> +comment "libsigrokcxx needs a toolchain w/ C++"
> +	depends on BR2_PACKAGE_LIBSIGROK

Instead of repeating this dependency here and in the definition of the
BR2_PACKAGE_LIBSIGROKCXX, I've simply placed both under a 'if
BR2_PACKAGE_LIBSIGROKCXX ... endif' condition.

Applied to next with those changes.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list