[Buildroot] [PATCH 1/1] dropbear: add extra build customization options

Floris Bos bos at je-eigen-domein.nl
Tue Feb 3 17:53:42 UTC 2015


Hi,

On 02/03/2015 03:04 PM, Thomas Petazzoni wrote:
> On Thu, 11 Sep 2014 17:43:31 +0200, Floris Bos wrote:
>
>> - Option to disable password authentication,
>>    to only allow public key authentication instead
> This can be done at runtime using the -s option, and presumably
> disabling it at build time doesn't give much space savings, so we'd
> rather not have a Config.in option for this.
>
>> - Option to disable TCP forwarding.
>>    Defaults to y, as most legitimate users are not using it,
>>    and the feature is very popular with spammers that scan
>>    for devices with weak passwords and use them to relay spam.
> This can be done at runtime using the -j and -k options, so same logic
> as for the password authentication disabling.

Fair enough


>
> We'd however be open to merge the option to install or not the clients,
> but we do have some comments/questions below.
>
>> +ifeq ($(BR2_PACKAGE_DROPBEAR_CLIENT),y)
>>   DROPBEAR_TARGET_BINS = dbclient dropbearkey dropbearconvert scp ssh
>>   DROPBEAR_MAKE =	$(MAKE) MULTI=1 SCPPROGRESS=1 \
>>   		PROGRAMS="dropbear dbclient dropbearkey dropbearconvert scp"
>> -
>> -DROPBEAR_LICENSE = MIT, BSD-2c-like, BSD-2c
>> -DROPBEAR_LICENSE_FILES = LICENSE
>> +else
>> +DROPBEAR_TARGET_BINS = dropbearkey dropbearconvert scp
>> +DROPBEAR_MAKE =	$(MAKE) MULTI=1 SCPPROGRESS=1 \
>> +		PROGRAMS="dropbear dropbearkey dropbearconvert scp"
>> +endif
> Why is scp part of the server-only installation?

Because scp is both a client and server program, similar to other 
programs that can tunnel data over SSH like rsync.
When using scp on the client, it simply calls the ssh client program to 
connect to the SSH server and executes scp server-side there with a flag 
to tell it to play server and read further instructions/data from stdin, 
send data to stdout.

Do could make building scp a seperate Config.in option.


Yours sincerely,

Floris Bos


More information about the buildroot mailing list