[Buildroot] [PATCH 2/2] Add hash file

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Feb 2 09:50:16 UTC 2015


Dear Steve Kenton,

On Mon,  2 Feb 2015 05:40:53 +0000, Steve Kenton wrote:
> Signed-off-by: Steve Kenton <skenton at ou.edu>
> ---
>  package/cdrtools/cdrtools.hash | 3 +++
>  1 file changed, 3 insertions(+)
>  create mode 100644 package/cdrtools/cdrtools.hash

This patch should not be separated from the previous, it should be
merged with it.

> 
> diff --git a/package/cdrtools/cdrtools.hash b/package/cdrtools/cdrtools.hash
> new file mode 100644
> index 0000000..c9f9c29
> --- /dev/null
> +++ b/package/cdrtools/cdrtools.hash
> @@ -0,0 +1,3 @@
> +cdrtools-3.00.tar.gz 	2010-06-02 	2.5 MB 	6363 weekly downloads 	i

This line doesn't make sense in a hash file. There should instead be a
comment saying where the hashes are coming from. Something like:

# From http://sourceforge.net/....

or

# Locally computed

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list