[Buildroot] [PATCHv2] core: add defconfig to .gitignore

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Dec 29 08:19:22 UTC 2015


Yann,

On Sun, 27 Dec 2015 21:44:46 +0100, Yann E. MORIN wrote:
> From: Karoly Kasza <kaszak at gmail.com>
> 
> After using "make safedefconfig", a defconfig file appears which is an
> extract of the .config file. When running git, it incorrectly detects it as a
> source code change.
> 
> Add /defconfig to .gitignore.
> 
> Signed-off-by: Karoly Kasza <kaszak at gmail.com>
> [yann.morin.1998 at free.fr: do not remove on distclean]
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

I continue to question whether this is the right thing to do.
"defconfig" is really only the default name, and it can be changed to
anything by changing BR2_DEFCONFIG. So should we gitignore the default
name, but not any other name?

I'm for the principle of least surprise, and I would personally find it
odd that we gitignore the default name only. Since we can't gitignore
all defconfigs, I'd prefer to not gitignore any of them.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list