[Buildroot] [PATCH v4 2/3] doom-wad: bump to version 1.9

Rodrigo Rebello rprebello at gmail.com
Wed Dec 23 23:59:08 UTC 2015


Thomas,

2015-12-23 20:37 GMT-02:00 Thomas Petazzoni
<thomas.petazzoni at free-electrons.com>:
> Dear Rodrigo Rebello,
>
> On Fri,  6 Nov 2015 17:47:58 -0200, Rodrigo Rebello wrote:
>
>> diff --git a/package/doom-wad/doom-wad.hash b/package/doom-wad/doom-wad.hash
>> new file mode 100644
>> index 0000000..fa069c1
>> --- /dev/null
>> +++ b/package/doom-wad/doom-wad.hash
>> @@ -0,0 +1,2 @@
>> +# Locally computed
>> +sha256       cacf0142b31ca1af00796b4a0339e07992ac5f21bc3f81e7532fe1b5e1b486e6        doom19s.zip
>> diff --git a/package/doom-wad/doom-wad.mk b/package/doom-wad/doom-wad.mk
>> index 6f4f9da..6c870d0 100644
>> --- a/package/doom-wad/doom-wad.mk
>> +++ b/package/doom-wad/doom-wad.mk
>> @@ -4,16 +4,18 @@
>>  #
>>  ################################################################################
>>
>> -DOOM_WAD_VERSION = 1.8
>> -DOOM_WAD_SOURCE = doom-$(DOOM_WAD_VERSION).wad.gz
>> +DOOM_WAD_VERSION = 1.9
>> +DOOM_WAD_SOURCE = doom19s.zip
>
> So shouldn't the version be "19" and not "1.9" ? It is a bit weird to
> have a version not used in the _SOURCE variable. Or if you really want
> to have 1.9 as the version, then:
>
>         DOOM_WAD_SOURCE = doom$(subst .,,$(DOOM_WAD_VERSION))s.zip
>

Indeed, I agree that looks a bit weird. I believe the zip filename
carries the number '19' instead of '1.9' merely because it dates back
to the old times of DOS, when its FAT filesystem imposed quite a few
limitations, like the dot character being allowed in a filename only
to separate it from its extension.

The correct version number, however, is really 1.9, so I'd prefer to
keep DOOM_WAD_VERSION untouched and apply the substitution you
proposed to the zip filename only. Would that be OK to you?

>>  DOOM_WAD_SITE = ftp://ftp.idsoftware.com/idstuff/doom
>
> However, the main reason I didn't apply is because this server seems to
> be unavailable at the moment. So I can't test the package, and it would
> cause build failures in the autobuilders.
>
> Are you also experiencing the same issue?
>

Yes, I have confirmed the server is unresponsive at the moment. I have
found an alternative URL that seems to work fine, though:

http://www.jbserver.com/downloads/games/doom/misc/shareware/doom19s.zip

Should I respin this patch with that temporary URL?

Regards,
Rodrigo

> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com


More information about the buildroot mailing list