[Buildroot] [PATCH v2 1/4] libfslcodec: add install hooks to fix libraries path

[Yann E. MORIN]

Gary, All,

On 2015-12-10 14:52 +0100, Gary Bisson spake thusly:
> By default, all the libraries are installed under /usr/lib/imx-mm which
> causes problems at runtime.
> 
> The hooks are inspired from the mechanism used in the Yocto recipe:
> https://github.com/Freescale/meta-fsl-arm/blob/fido/recipes-
> multimedia/libfslcodec/libfslcodec.inc
> 
> Signed-off-by: Gary Bisson <gary.bisson at boundarydevices.com>
> ---
> 
> Here are the dependencies the pipelines above are testing:
> $ for i in `find target/usr/lib/gstreamer*/*`; do readelf -d $i | grep NEEDED | grep lib_ && echo "($i)"; done
>  0x00000001 (NEEDED)                     Shared library: [lib_nb_amr_dec_arm9_elinux.so.2]
>  0x00000001 (NEEDED)                     Shared library: [lib_wb_amr_dec_arm9_elinux.so.2]
> (target/usr/lib/gstreamer-0.10/libmfw_gst_amrdec.so)
>  0x00000001 (NEEDED)                     Shared library: [lib_peq_arm11_elinux.so.1.fhw]
> (target/usr/lib/gstreamer-0.10/libmfw_gst_audio_pp.so)
>  0x00000001 (NEEDED)                     Shared library: [lib_mp3_enc_arm12_elinux.so.2]
> (target/usr/lib/gstreamer-0.10/libmfw_gst_mp3enc.so)
>  0x00000001 (NEEDED)                     Shared library: [lib_mp3_enc_arm12_elinux.so.2]
> (target/usr/lib/gstreamer-1.0/libgstimxaudio.so)
> 
> Note that I added a staging install hook as well because otherwise the
> gst1-imx plugin doesn't find lib_mp3_enc_arm12_elinux.so at build time.
> 
> Not to copy the same library twice I decided to go with a symlink. Let
> me know if that's acceptable.

The link you pointed to does a move, not a copy. Why do you do a symlink?

1) Where are the libraries searched for at build time? If they are
   only searched for in /usr/lib/ , then do a move. If womething is
   positively looking for them in /usr/lin/imx-mm/ , then do a symlink,
   indeed.

2) Where are libraries searched for at runtime? Same logic as for build
   time.

Regards,
Yann E. MORIN.

> Regards,
> Gary
> 
> ---
>  package/libfslcodec/libfslcodec.mk | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/package/libfslcodec/libfslcodec.mk b/package/libfslcodec/libfslcodec.mk
> index 473d662..f8c6aa8 100644
> --- a/package/libfslcodec/libfslcodec.mk
> +++ b/package/libfslcodec/libfslcodec.mk
> @@ -20,4 +20,19 @@ endef
>  # FIXME The Makefile installs both the arm9 and arm11 versions of the
>  # libraries, but we only need one of them.
>  
> +# Use symlinks in staging dir so every application can link against the libs
> +# whether they look at imx-mm or not (gst-fsl-plugins vs. gst1-imx).
> +define LIBFSLCODEC_FIXUP_STAGING_PATH
> +	find $(STAGING_DIR)/usr/lib/imx-mm -mindepth 2 -maxdepth 2 -not -type d \
> +		-exec ln -fs {} $(STAGING_DIR)/usr/lib \;
> +endef
> +LIBFSLCODEC_POST_INSTALL_STAGING_HOOKS += LIBFSLCODEC_FIXUP_STAGING_PATH
> +
> +# Use symlinks in install dir as well to match staging setup.
> +define LIBFSLCODEC_FIXUP_TARGET_PATH
> +	find $(TARGET_DIR)/usr/lib/imx-mm -mindepth 2 -maxdepth 2 -not -type d \
> +		-exec ln -fs {} $(TARGET_DIR)/usr/lib \;
> +endef
> +LIBFSLCODEC_POST_INSTALL_TARGET_HOOKS += LIBFSLCODEC_FIXUP_TARGET_PATH
> +
>  $(eval $(autotools-package))
> -- 
> 2.6.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'