[Buildroot] [PATCH 1/2] wine: Make the sane-config patch obsolete by using configure flags

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Dec 8 08:48:15 UTC 2015


André,

On Mon, 7 Dec 2015 21:39:22 +0100, André Hentschel wrote:
> Signed-off-by: André Hentschel <nerv at dawncrow.de>
> ---
>  package/wine/0003-sane-config-fix.patch | 21 ---------------------
>  package/wine/wine.mk                    |  3 ++-
>  2 files changed, 2 insertions(+), 22 deletions(-)
>  delete mode 100644 package/wine/0003-sane-config-fix.patch

IMO, this is not the good choice. The patch should be kept and
submitted upstream. There is absolutely no reason for upstream to
reject the patch: it simply *adds* the possibility of passing a custom
sane-config path through SANE_CONFIG, without changing *anything* to
the existing behavior if SANE_CONFIG is not used.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list