[Buildroot] [PATCH v6] package/unscd: new package
rdkehn at yahoo.com
rdkehn at yahoo.com
Wed Dec 2 13:00:24 UTC 2015
Hi Thomas and Arnout,
On Tue, Dec 01, 2015 at 10:45:06PM +0100, Thomas Petazzoni wrote:
> Dear Arnout Vandecappelle,
>
> On Tue, 1 Dec 2015 22:37:15 +0100, Arnout Vandecappelle wrote:
>
> > > +define UNSCD_EXTRACT_CMDS
> > > + cp $(DL_DIR)/$($(PKG)_SOURCE) $(@D)/nscd.c
> > > +endef
> > > +
> > > +define UNSCD_BUILD_CMDS
> > > + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) nscd
> >
> > Although it works because of the default rules, it looks very strange to me to
> > call make when there is no Makefile. I would instead call the compiler directly:
> >
> > cd $(@D); \
> > $(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) -o nscd nscd.c
> >
> > What do the others think?
>
> Fully agree with you.
I will change as suggested. For what it's worth, I was following the
whetstone recipe (which is also a single source file).
Regards,
...doug
More information about the buildroot
mailing list