[Buildroot] [PATCH 1/1] gnuradio: stat.h is need for mode_t

gwenhael.goavec gwenj at trabucayre.com
Fri Aug 28 15:27:10 UTC 2015


Dear Vicente Olivert Riera
On Fri, 28 Aug 2015 16:09:37 +0100
Vicente Olivert Riera <Vincent.Riera at imgtec.com> wrote:

> Dear Gwenhael Goavec-Merou,
> 
> On 08/28/2015 03:47 PM, Gwenhael Goavec-Merou wrote:
> > From: Gwenhael Goavec-Merou <gwenhael.goavec-merou at trabucayre.com>
> > 
> > fix :
> > http://autobuild.buildroot.net/results/8e3/8e3afd5f22312f0660f631fdb82bbb64eda913fb/build-end.log
> > 
> > error: 'mode_t' has not been declared
> > 
> > Signed-off-by: Gwenhael Goavec-Merou
> > <gwenhael.goavec-merou at trabucayre.com> ---
> >  package/gnuradio/0002-stat_t-is-need-for-mode_t.patch | 13
> > +++++++++++++ 1 file changed, 13 insertions(+)
> >  create mode 100644
> > package/gnuradio/0002-stat_t-is-need-for-mode_t.patch
> > 
> > diff --git a/package/gnuradio/0002-stat_t-is-need-for-mode_t.patch
> > b/package/gnuradio/0002-stat_t-is-need-for-mode_t.patch new file
> > mode 100644 index 0000000..391a12f
> > --- /dev/null
> > +++ b/package/gnuradio/0002-stat_t-is-need-for-mode_t.patch
> > @@ -0,0 +1,13 @@
> > +Index: gnuradio-3.7.5/gnuradio-runtime/include/gnuradio/logger.h.in
> > +===================================================================
> > +---
> > gnuradio-3.7.5.orig/gnuradio-runtime/include/gnuradio/logger.h.in
> > ++++ gnuradio-3.7.5/gnuradio-runtime/include/gnuradio/logger.h.in
> > +@@ -44,6 +44,8 @@
> > + 
> > + #ifdef _MSC_VER
> > + typedef unsigned short mode_t;
> > ++#else
> > ++#include <sys/stat.h>
> > + #endif
> > + 
> > + #include <gnuradio/api.h>
> > 
> 
> I cannot see that change upstream, so I will assume that you haven't
> backported this patch from it:
> 
> http://gnuradio.org/redmine/projects/gnuradio/repository/revisions/master/entry/gnuradio-runtime/include/gnuradio/logger.h.in
> 
No it's not a backport.

> Have you tried to submit it your patch upstream? It would be nice if
> the upstream package is fixed as well, so we can just backport the
> patch from it, or even better, bump our version to one which has that
> problem fixed.
> 
No. I'm agree with you about the need to send this patch to gnuradio
but, currently, I'm not sure it's a global problem with all
toolchains or strictly related to musl. 
> Regards,
> 
> Vincent.

Regards,
Gwenhael.


More information about the buildroot mailing list