[Buildroot] [PATCH 1/1] rapidxml: new package

Baruch Siach baruch at tkos.co.il
Tue Aug 4 20:40:11 UTC 2015


Hi Yonatan,

On Tue, Aug 04, 2015 at 07:37:14PM +0300, Jonathan Ben Avraham wrote:
> >On Mon, Aug 03, 2015 at 09:04:14PM +0300, Jonathan Ben-Avraham wrote:
> >>+RAPIDXML_INSTALL_TARGET = NO
> >
> >This needs an explanation comment. Is this a header only package?
> >
> >>+RAPIDXML_INSTALL_STAGING = YES

[snip]

> Regarding "This needs an explanation comment. Is this a header only
> package?", you can see from RAPIDXML_INSTALL_TARGET = NO and
> RAPIDXML_INSTALL_STAGING = YES that the answer must be "yes". I did not see
> a need to add a comment since the precedent package "rapidjson", also has no
> comment.

Set precedents are not always a good guide. That's the case here, IMO.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -


More information about the buildroot mailing list