[Buildroot] [PATCH 1/1] busybox: udhcpc create leases file

Peter Korsgaard peter at korsgaard.com
Thu Apr 30 14:31:05 UTC 2015


>>>>> "Matt" == Matt Weber <matt at thewebers.ws> writes:

 > Signed-off-by: Matt Weber <matt at thewebers.ws>
 > ---
 >  package/busybox/udhcpc.script | 23 +++++++++++++++++++++++
 >  1 file changed, 23 insertions(+)

 > diff --git a/package/busybox/udhcpc.script b/package/busybox/udhcpc.script
 > index 50c52e6..d5d81bf 100755
 > --- a/package/busybox/udhcpc.script
 > +++ b/package/busybox/udhcpc.script
 > @@ -61,6 +61,29 @@ case "$1" in
 >  			echo adding dns $i
 >  			echo "nameserver $i # $interface" >> $RESOLV_CONF
 >  		done
 > +
 > +		# Based on http://sourceforge.net/p/kboot/mailman/message/1168535/

A more detailed commit message would be good. After looking at that URL
I'm still not quite sure what this is needed for? It doesn't seem to be
read again anywhere.

> +		} >> /var/lib/misc/udhcpc-$interface.leases

Are you sure this should append the file and not overwrite it? Why would
you want to keep older lease info around when you receive a new one?

Perhaps this belongs in a hook in your rootfs overlay?

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list