[Buildroot] [PATCH 1/2] package/ccache: bump to version 3.2.1

Károly Kasza kaszak at gmail.com
Sun Apr 26 09:38:52 UTC 2015


Hello Baruch,

> -HOST_CCACHE_CONF_OPTS += ccache_cv_zlib_1_2_3=no
> > +HOST_CCACHE_CONF_OPTS += --with-bundled-zlib
>


> > -     sed -i 's,getenv("CCACHE_COMPILERCHECK"),"none",' $(@D)/ccache.c
> > -     sed -i 's,"%s/.ccache","$(BR_CACHE_DIR)",' $(@D)/ccache.c
> > +     sed -i 's,conf->compiler_check =
> x_strdup("mtime"),conf->compiler_check = x_strdup("none"),' $(@D)/conf.c
> > +     sed -i 's,"%s/.ccache","$(BR_CACHE_DIR)",' $(@D)/conf.c
>
>

> You are doing non trivial changes here and above. Please explain in a
> commit
> log what you are doing, and why this is needed as part of the version bump.
>

As you probably see, those lines do the exact same as before, just the
structure of the ccache sources changed with the major version bump. I'll
wait for some comments on the second patch regarding the introduction of a
wrapper script and resend with a more informative git log.

Kind regards,
Karoly
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150426/6a315ca3/attachment.html>


More information about the buildroot mailing list