[Buildroot] [PATCHv2 03/21] Makefile: targets are now declared phony by the appropriate infrastructures
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Tue Apr 14 08:17:45 UTC 2015
Dear Yann E. MORIN,
On Mon, 13 Apr 2015 21:44:33 +0200, Yann E. MORIN wrote:
> Since you first posted that series, the 'list-defconfig' was introduced
> by Arnout, and your patch removes it from being a PHONY target, which it
> should be...
>
> > - $(TARGETS) $(TARGETS_ROOTFS) \
> > - $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) $(TARGETS_LEGAL_INFO)
> > + target-finalize target-post-image
>
> ... so should be kept in there.
>
> When you fix that, you can keep my reviewd-by tag.
Wow, great, thanks for spotting! Obviously an incorrect rebase conflict
resolution on my side. I've fixed that up before applying the patch.
Thanks again for the thorough review!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list