[Buildroot] [PATCH 2/2] infra/pkg-kconfig: require an non-empty KCONFIG_FILE

Yann E. MORIN yann.morin.1998 at free.fr
Fri Apr 10 20:40:30 UTC 2015


Arnout, All,

On 2015-04-10 22:01 +0200, Arnout Vandecappelle spake thusly:
> On 08/04/15 22:49, Yann E. MORIN wrote:
> [snip]
> > So, because neither "use defconfig" nor "use custom config" is set,
> > KERNEL_SOURCE_CONFIG is not set, so LINUX_KCONFIG_FILE ends up empty.
> 
> 
> BR2_LINUX_KERNEL_USE_DEFCONFIG and BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG are the
> only two possibilities in the "Kernel configuration" choice, so one of them will
> always be set.

No, neither would be set if you don't enable building a kernel. In that
case, LINUX_KCONFIG_FILE is empty, but the $(eval $(kconfig-package)) is
still called, and thus the test should fail. But it does not.

> > However, our ifndef did not trigger so far.
> 
>  The kernel isn't built in the autobuilders, so where would it trigger?

Well, obviously, locally. ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list