[Buildroot] [PATCH 14/18] package/mplayer: add optional libiconv support

Yann E. MORIN yann.morin.1998 at free.fr
Wed Apr 8 21:30:08 UTC 2015


Bernd, All,

On 2015-03-29 19:11 +0200, Bernd Kuhls spake thusly:
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
> ---
>  package/mplayer/mplayer.mk |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/package/mplayer/mplayer.mk b/package/mplayer/mplayer.mk
> index 631e2fe..6d9c4f4 100644
> --- a/package/mplayer/mplayer.mk
> +++ b/package/mplayer/mplayer.mk
> @@ -68,6 +68,14 @@ else
>  MPLAYER_CONF_OPTS += --disable-enca
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBICONV),y)
> +MPLAYER_CONF_OPTS += --enable-iconv
> +MPLAYER_DEPENDENCIES += libiconv
> +MPLAYER_EXTRA_LIBS += -liconv

Even though that's jsut been merged, I think this has the same issue as
the librtmp: ./configure will find the appropriate CFLAGS/LIBS if not
explicitly told to use iconv, so I'd just add the dependency (like
already suggested for librtmp).

Care to address that ad send a respin, please?

Regards,
Yann E. MORIN.

> +else
> +MPLAYER_CONF_OPTS += --disable-iconv
> +endif
> +
>  ifeq ($(BR2_PACKAGE_NCURSES),y)
>  MPLAYER_CONF_OPTS += --enable-termcap
>  MPLAYER_DEPENDENCIES += ncurses
> -- 
> 1.7.10.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list