[Buildroot] [PATCH] pkg-utils: qstrip MESSAGE

Peter Korsgaard jacmet at uclibc.org
Mon Sep 29 06:44:39 UTC 2014


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > Currently, the MESSAGE macro double-quotes the message. But a few call
 > sites also double-quote the message, resulting in a borked call to echo,
 > like:
 >     $(call MESSAGE,"user text")
 > would expand to:
 >     echo "Leading text "user message" trailign text"

 > Just use qstrip on the user message, so we get protected from either a
 > comma in the user text (so make does not interpret it), or a semi-colon
 > (so the shell does not interpret it.)

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
 > Cc: Peter Korsgaard <jacmet at uclibc.org>
 > Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list