[Buildroot] [PATCH] pkg-utils: the MESSAGE macro already double-quotes the message

Danomi Manchego danomimanchego123 at gmail.com
Thu Sep 18 23:54:18 UTC 2014


Yann,

On Thu, Sep 18, 2014 at 6:28 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> ... so passing a double-quoted message to the macro defeats the quoting
> altogether.
>
> Remove double-quotation of messages. Change made with:
>     $ sed -r -i -e 's/(call MESSAGE,)"(.*)"\)/\1\2)/g' \
>           $(git grep -l -E 'call MESSAGE."')
>

If there's any virtue to limiting the patch, I think that you could
end the quotes in MESSAGE before the $1, and resume them after the $1,
and then leave the quotes in all those files:

MESSAGE     = echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION)
"$(1)"$(TERM_RESET)"

                                                                ^
^

Danomi -


More information about the buildroot mailing list