[Buildroot] [PATCH 3/4] arch: do not distinguish revisions of ARM1136JF-S

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Sep 15 21:39:16 UTC 2014


Dear Yann E. MORIN,

On Mon, 15 Sep 2014 23:33:39 +0200, Yann E. MORIN wrote:

> > Note that the removal of the two options should not break existing
> > full .config, since the hidden option BR2_arm1136jf_s becomes again a
> > visible option to select the CPU.
> 
> But it would break a defconfig.

Right. But I believe that when we change the default value of an
option, we also break a defconfig, and we don't include that as part of
the Config.in.legacy handling (but also because it's obviously more
complicated).

> As suggested on IRC, move the BR2_arm1136jf_s_r1 to Config.legacy, and
> have it select BR2_arm1136jf_s, so the user can re-use a defconfig.

Hum, why just BR2_arm1136jf_s_r1 and not BR2_arm1136jf_s_r0 ?

Thanks for the review!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list