[Buildroot] [PATCH v3] gcc: explicitly use C{XX}FLAGS_FOR_TARGET instead of --enable-target-optspace

Alexey Brodkin Alexey.Brodkin at synopsys.com
Mon Sep 1 07:53:08 UTC 2014


Hi Thomas,

On Mon, 2014-09-01 at 09:25 +0200, Thomas Petazzoni wrote:
> Dear Alexey Brodkin,
> 
> On Mon,  1 Sep 2014 10:32:45 +0400, Alexey Brodkin wrote:
> 
> >  # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43810
> >  # Workaround until it's fixed in 4.5.4 or later
> >  ifeq ($(ARCH),powerpc)
> >  ifeq ($(findstring x4.5.,x$(GCC_VERSION)),x4.5.)
> > -HOST_GCC_COMMON_CONF_OPT += --disable-target-optspace
> > +GCC_COMMON_TARGET_CFLAGS := $(filter-out -Os,$(GCC_COMMON_TARGET_CFLAGS))
> > +GCC_COMMON_TARGET_CXXFLAGS := $(filter-out -Os,$(GCC_COMMON_TARGET_CXXFLAGS))
> 
> Is there any reason to use := instead of = here? We normally use =
> except when it's really necessary to use :=.

Nope I think I just copy-pasted it here - which is not the best thing I
could have done. Looks like in this particular case there's no need to
use ":=" and "=" will work well.

So will fix this tiny "misspelling" shortly in v4.

-Alexey


More information about the buildroot mailing list