[Buildroot] [PATCH] Complain loudly if BR2_GLOBAL_PATCH_DIR does not exit
Yann E. MORIN
yann.morin.1998 at free.fr
Tue Oct 21 16:58:17 UTC 2014
Michal, All,
On 2014-10-21 10:42 +0200, Michal Sojka spake thusly:
> If the BR2_GLOBAL_PATCH_DIR is misspelled in the .config or if somebody
> renamed the existing directory with patches, buildroot happily builds
> everything but without the patches. As this can lead to surprising
> results,
Indeed... :-/
> it is better to fail and give a user a message that
> BR2_GLOBAL_PATCH_DIR is wrongly configured.
>
> Signed-off-by: Michal Sojka <sojka at merica.cz>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Regards,
Yann E. MORIN.
> ---
> package/pkg-generic.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 259ee02..46d92aa 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -162,6 +162,11 @@ $(BUILD_DIR)/%/.stamp_patched:
> $(Q)touch $@
> @$(call step_end,patch)
>
> +# Check that all directories specified in BR2_GLOBAL_PATCH_DIR exist.
> +$(foreach dir,$(call qstrip,$(BR2_GLOBAL_PATCH_DIR)),\
> + $(if $(wildcard $(dir)),,\
> + $(error BR2_GLOBAL_PATCH_DIR contains nonexistent directory $(dir))))
> +
> # Configure
> $(BUILD_DIR)/%/.stamp_configured:
> @$(call step_start,configure)
> --
> 2.1.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list