[Buildroot] [PATCH] tinyalsa: new package

[Maxime Hadjinlian]

On Sat, Oct 18, 2014 at 3:02 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Maarten ter Huurne,
>
> On Sat, 18 Oct 2014 02:42:45 +0200, Maarten ter Huurne wrote:
>
>> > +++ b/package/tinyalsa/tinyalsa.mk
>> > [snip]
>> > +       $(INSTALL) -D -m 0644 $(@D)/include/sound/asound.h \
>> > +                       $(STAGING_DIR)/usr/include/sound/asound.h
>>
>> This will overwrite the pre-existing (from libc or kernel headers) version
>> of <sound/asound.h> with the Android-style stripped version from tinyalsa.
>> I think it would be better to keep the pre-existing version of this header,
>> do you agree?
>
> Yes, overwriting this header file indeed looks brutal. Is the original
> asound.h a superset of the tinyalsa asound.h ? If that's the case, then
> we can simply keep the original asound.h and that's it.
Indeed, I originally though they were different headers, after doing a
diff between the two, the one of tinyalsa is simply a subset. I'll
submit a patch to remove the install.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com