[Buildroot] [PATCH] fs/iso9660: add dependencies for make source

Maxime Hadjinlian maxime.hadjinlian at gmail.com
Sat Oct 18 10:31:11 UTC 2014


Hi Karoly, all

On Fri, Oct 17, 2014 at 11:16 PM, Karoly Kasza <kaszak at gmail.com> wrote:
> The "iso image" rootfs target is a special one, as it does not use the
> ROOTFS_TARGET infrastructure. The absence of ROOTFS_*_DEPENDENCIES
> variable makes "make source" to skip this target's dependencies
> (namely host-cdrkit and it's children) obstructing an offline build.
>
> Signed-off-by: Karoly Kasza <kaszak at gmail.com>
> ---
>  fs/iso9660/iso9660.mk |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fs/iso9660/iso9660.mk b/fs/iso9660/iso9660.mk
> index b0e755d..5137026 100644
> --- a/fs/iso9660/iso9660.mk
> +++ b/fs/iso9660/iso9660.mk
> @@ -10,6 +10,8 @@
>  ISO9660_TARGET_DIR = $(BUILD_DIR)/iso9660
>  ISO9660_BOOT_MENU := $(call qstrip,$(BR2_TARGET_ROOTFS_ISO9660_BOOT_MENU))
>
> +ROOTFS_ISO9660_DEPENDENCIES = host-cdrkit host-fakeroot linux rootfs-cpio grub
> +
>  $(BINARIES_DIR)/rootfs.iso9660: host-cdrkit host-fakeroot linux rootfs-cpio grub
>         @$(call MESSAGE,"Generating root filesystem image rootfs.iso9660")
>         mkdir -p $(ISO9660_TARGET_DIR)
> --
> 1.7.10.4
How about putting the dependencies variables on the top ?
Also, please keep the dependencies alphabetically sorted.
I know they are not ordered the line below, but it would be nice.
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot


More information about the buildroot mailing list