[Buildroot] [PATCH] spidev_test: new package

Yann E. MORIN yann.morin.1998 at free.fr
Fri Oct 17 21:55:39 UTC 2014


Baruch, All,

On 2014-10-14 22:54 +0300, Baruch Siach spake thusly:
> On Tue, Oct 14, 2014 at 12:45:53PM -0300, Gustavo Zacarias wrote:
> > Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
> 
> [snip]
> 
> > diff --git a/package/spidev_test/Config.in b/package/spidev_test/Config.in
> > new file mode 100644
> > index 0000000..c0ed9ef
> > --- /dev/null
> > +++ b/package/spidev_test/Config.in
> > @@ -0,0 +1,15 @@
> > +config BR2_PACKAGE_SPIDEV_TEST
> > +	bool "spidev_test"
> > +	depends on BR2_LINUX_KERNEL
> 
> That is a heavy dependency. As you noted in another message, it also make the 
> autobuilder skip this package. I suggest to download just spidev_test.c from 
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/plain/Documentation/spi/spidev_test.c?id=$(SPIDEV_TEST_VERSION), 
> and make it depend on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15 (as of v3.17). This 

What about directly getting the appropriate one, something like:

    ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15),y)
    SPIDEV_TEST_VERSION = v3.15
    else
    SPIDEV_TEST_VERSION = v3.14
    endif

    SPIDEV_TEST_SOURCE =
    SPIDEV_TEST_EXTRA_DOWNLOADS = http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/plain/Documentation/spi/spidev_test.c?id=$(SPIDEV_TEST_VERSION)

Since, without the proper kernel headers, it is not possible to build
the quad-pump blabla, we can directly get the spidev_test that will
indeed compile with our toolchain, no?

Regards,
Yann E. MORIN.



-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list