[Buildroot] [PATCH buildroot-test 6/8] autobuild-run: create main method to locally-scope all variables

Thomas De Schampheleire patrickdepinguin at gmail.com
Thu Oct 16 19:16:02 UTC 2014


From: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>

In the current autobuild-run script, all variables created in the 'main'
part are in fact global, even though the script does not intend them to
be. For example, sysinfo is global, even though it is passed as function
argument to run_instance.

To avoid this accidental globalization, create a main method instead.
All variables created therein are now local to that method.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
---
 scripts/autobuild-run | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 57654de..95f2390 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -575,7 +575,7 @@ def merge(dict_1, dict_2):
     return dict((str(key), dict_1.get(key) or dict_2.get(key))
                 for key in set(dict_2) | set(dict_1))
 
-if __name__ == '__main__':
+def main():
     check_version()
     sysinfo = SystemInfo()
 
@@ -604,3 +604,6 @@ if __name__ == '__main__':
     signal.signal(signal.SIGTERM, sigterm_handler)
     for p in processes:
         p.join()
+
+if __name__ == '__main__':
+    main()
-- 
1.8.5.1



More information about the buildroot mailing list