[Buildroot] [PATCH 14/25 v6] docs/manual: allow documents to define some hooks, as for a package

Thomas De Schampheleire patrickdepinguin at gmail.com
Wed Oct 1 19:58:56 UTC 2014


On Sat, Sep 27, 2014 at 12:16 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> Allow documents to define two hooks:
>   - DOC_CHECK_EXTRA_DEPENDENCIES_HOOKS
>     to check for extra dependencies required by this document
>   - DOC_CHECK_EXTRA_DEPENDENCIES_FMT_HOOKS
>     ditto, but for the specific format
>   - DOC_POST_EXTRACT_HOOKS:
>     to run additional actions to fill-in the build directory
>
> (Replace 'DOC' with the uppercase name of the document, and 'FMT' with
> the format.)
>
> This is supposed to replace the current use of overloading the internal
> dependency rules, and makes GENDOC behave yet a bit more like the
> package infrastructure.
>
> Note that GENDOC_INNER already has the uppercase name as an argument,
> whereas GENDOC does not, so the two foreach loops are not exactly
> similar (for now.)
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Samuel Martin <s.martin49 at gmail.com>
> Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
> Reviewed-by: Samuel Martin <s.martin49 at gmail.com>
>
> ---
> Changes v5 -> v6:
>   - do not use $$ for call to UPPERCASE  (Thomas DS)
>

Here the same misunderstanding occurred. In these cases, I do think $$
should be used.

If the resulting patch is the same as v5, my Ack on that still counts.


More information about the buildroot mailing list