[Buildroot] [PATCH 1/2 v2] package/util-linux: libuuid needs -lintl

Peter Korsgaard peter at korsgaard.com
Sun Nov 30 23:19:30 UTC 2014


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > When gettext is needed (with locales), libuuid needs to be linked
 > against -lintl.

 > In dynamic link, this is solved via the DT_NEEDED ELF tag, but for
 > static links, it does not get pulled in automatically.

 > Fix that by adding a Libs.private section to uuid.pc, but only if
 > it needed.

 > First part at fixing:
 >     http://autobuild.buildroot.net/results/c46/c467aeec258909bb82eda77123803944f97d8df8/

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
 > Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
 > Cc: Baruch Siach <baruch at tkos.co.il>

 > ---
 > Changes v1 -> v2:
 >   - typo  (Baruch)
 > ---
 >  package/util-linux/util-linux.mk | 8 ++++++++
 >  1 file changed, 8 insertions(+)

 > diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
 > index 6ecd16d..dc10193 100644
 > --- a/package/util-linux/util-linux.mk
 > +++ b/package/util-linux/util-linux.mk
 > @@ -128,6 +128,14 @@ endif
 
 >  UTIL_LINUX_POST_INSTALL_TARGET_HOOKS += UTIL_LINUX_GETTY_SYMLINK
 
 > +ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE)$(BR2_PACKAGE_UTIL_LINUX_LIBUUID),yy)
 > +define UTIL_LINUX_TWEAK_UUID_PC
 > +	$(SED) '/Libs\.private: .*/d' $(STAGING_DIR)/usr/lib/pkgconfig/uuid.pc
 > +	printf "Libs.private: -lintl\n" >>$(STAGING_DIR)/usr/lib/pkgconfig/uuid.pc
 > +endef

As discussed on IRC, I don't think the SED line is needed - But lets
leave it here to be on the safe side.

Committed, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list