[Buildroot] [PATCH 1/2] package/openssl: Enable parallel build

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 > Dear Bernd Kuhls,
 > On Sun, 16 Nov 2014 15:00:45 +0100, Bernd Kuhls wrote:
 >> Patch taken from Gentoo, tested 50+ times on buildroot with make -j80.
 >> 
 >> Comparison of compile duration:
 >> 
 >> make -j1
 >> real    1m24.464s
 >> user    1m8.620s
 >> sys     0m9.661s
 >> 
 >> make -j80
 >> real    0m27.774s
 >> user    1m34.234s
 >> sys     0m13.441s
 >> 
 >> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
 >> ---
 >> package/openssl/openssl-005-parallel-build.patch |  363 ++++++++++++++++++++++
 >> package/openssl/openssl.mk                       |   10 +-
 >> 2 files changed, 368 insertions(+), 5 deletions(-)
 >> create mode 100644 package/openssl/openssl-005-parallel-build.patch

 > Unfortunately, this patch is a fairly large patch, which is more a
 > feature patch than a real fix. Could we instead get it merged upstream?

 > I discussed this with Yann, and I believe Peter will agree that it's a
 > feature patch that we shouldn't take in Buildroot. The solutions are
 > either to take this patch upstream, or in Buildroot build in parallel
 > and then fallback to serial build if the parallel build has failed.

> Something along the lines of:

 > 	$(MAKE) -C $(@D) || $(MAKE1) -C $(@D)

Yes, we discussed it on IRC, but I haven't gotten around to write an
email yet.

I completely agree with the above. Considering what package it is, and
the amount of trouble other distributions (E.G. the big Debian openssl
issue) has had with carrying openssl patches, and the fact that the
above speedup (~1 minute in the best case) is relatively small compared
to the typical build time, I would also reject it until it get merged
upstream.

-- 
Bye, Peter Korsgaard