[Buildroot] [PATCH v3 1/5] Makefile: don't depend on the umask
Yann E. MORIN
yann.morin.1998 at free.fr
Mon Nov 17 21:36:45 UTC 2014
Guido, All,
On 2014-11-17 14:19 -0300, Guido Martínez spake thusly:
> Some packages and BR itself create files and directories on the target
> with cp/mkdir/etc which depend on the umask at the time of building.
>
> To fix this, use a trick inside the Makefile which wraps all rules when
> the umask is not 0022. This sets the umask at the top level, and then
> the building process continues as usual.
>
> Signed-off-by: Guido Martínez <guido at vanguardiasur.com.ar>
> ---
> Makefile | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 471edf9..5ad8235 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -24,6 +24,19 @@
> # You shouldn't need to mess with anything beyond this point...
> #--------------------------------------------------------------
>
> +# Trick for always running with a fixed umask
> +UMASK=0022
> +ifneq ($(shell umask),$(UMASK))
> +.PHONY:*
> +
> +all:
> + @umask $(UMASK) && make --no-print-directory
You should use $(MAKE) instead of just 'make'.
I'm not too fond of --no-print-directory, because it is gonna be
inherited by all sub-makes, and especially the sub-makes that actually
build the packages. I don't care we have an extra "Entering directory"
message.
Also, did you check how that plays with top-level parallel builds? I'm
not too fond of it, but some users want to use it. See the comment a bit
further in the Makefile.
> +
> +%:
> + @umask $(UMASK) && make --no-print-directory $@
Ditto.
Regards,
Yann E. MORIN.
> +else # umask
> +
> # This is our default rule, so must come first
> all:
>
> @@ -932,3 +945,5 @@ include docs/manual/manual.mk
> -include $(BR2_EXTERNAL)/docs/*/*.mk
>
> .PHONY: $(noconfig_targets)
> +
> +endif #umask
> --
> 2.1.3
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list