[Buildroot] [PATCHv2 3/3] quota: fix static linking

Peter Korsgaard jacmet at uclibc.org
Sun Nov 9 20:52:48 UTC 2014


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 > The aim of this patch is to fix bug #7574, i.e fix the static linking
 > of the quota package. It does so by introducing a patch to the quota
 > build system that generalizes the use of $(LIBS), and then changes
 > quota.mk to use LIBS instead of LDFLAGS to link against intl and tirpc
 > when needed.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
 > ---
 >  package/quota/02-fix-static-linking.patch | 55 +++++++++++++++++++++++++++++++
 >  package/quota/quota.mk                    |  9 +++--
 >  2 files changed, 59 insertions(+), 5 deletions(-)
 >  create mode 100644 package/quota/02-fix-static-linking.patch

 > diff --git a/package/quota/02-fix-static-linking.patch b/package/quota/02-fix-static-linking.patch
 > new file mode 100644
 > index 0000000..fd73f64
 > --- /dev/null
 > +++ b/package/quota/02-fix-static-linking.patch
 > @@ -0,0 +1,55 @@
 > +Use $(LIBS) properly
 > +
 > +This patch makes sure the quota build system uses $(LIBS) where
 > +appropriate, so that it can be used to link with additional libraries,
 > +which is needed when linking statically.

This patch could be simplified quite a bit if you just did s/LIBS/LDLIBS/
so the existing implicit rules can be used, then we only need to adjust
the explicit link rules (for quotecheck, warnquota, rpc.rquotad), but
Ok.

Committed, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list