[Buildroot] [PATCH 2/3] qt5enginio: new package

[Peter Korsgaard]

>>>>> "Fatih" == Fatih Aşıcı <fatih.asici at gmail.com> writes:

Hi,

 >> > +config BR2_PACKAGE_QT5ENGINIO
 >> > +	bool "qt5enginio"
 >> > +	select BR2_PACKAGE_OPENSSL
 >> > +	select BR2_PACKAGE_QT5BASE
 >> > +	select BR2_PACKAGE_QT5BASE_GUI
 >> > +	select BR2_PACKAGE_QT5BASE_NETWORK
 >> 
 >> <snip>
 >> 
 >> > +QT5ENGINIO_DEPENDENCIES = qt5base
 >> 
 >> You forgot to add openssl to _DEPENDENCIES.

 > openssl is not a direct dependency of this package. It needs an openssl-
 > enabled qt5base. qt5base has openssl in its _DEPENDENCIES variable.

Ahh, ok - That wasn't clear to me.

 > In this case, do I really need to add this dependency to this package?

It cannot hurt. I would say you should either:

 - Add openssl to _DEPENDENCIES
 - Add a comment after the 'select BR2_PACKAGE_OPENSSL' to explain why
   (similar to how we do for runtime dependencies)

-- 
Bye, Peter Korsgaard