[Buildroot] [PATCH] libnss: Enable for MIPS64 n32 platforms

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu May 22 10:46:02 UTC 2014


Dear Vicente Olivert Riera,

On Thu, 22 May 2014 11:11:52 +0100, Vicente Olivert Riera wrote:

> >> -ifeq ($(BR2_ARCH_IS_64),y)
> >> +ifeq ($(BR2_ARCH_IS_64)$(BR2_MIPS_NABI32),yn)
> >
> > This cannot work: when an option is disabled, its value is empty, not
> > 'n'.
> >
> > So:
> >
> > # a comment here that explains the exception for MIPS_NABI32
> > ifeq ($(BR2_ARCH_IS_64),y)
> > ifeq ($(BR2_MIPS_NABI32),)
> > ...
> > endif
> > endif
> >
> > Thanks!
> >
> > Thomas
> >
> 
> I tried it and it worked.

Yes, it worked in your case, because the condition had to be false in
your case. But with your implementation, the condition will *always* be
false, so the USE_64 thing will no longer be passed for BR2_ARCH_IS_64
situations that are *not* BR2_MIPS_NABI32.

Thomsa
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list