[Buildroot] [buildroot][PATCH 1/3] isl: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon May 19 09:39:20 UTC 2014


Dear Steve Thomas,

Thanks, this is better, but you haven't taken into account all the
comments I posted about your previous version.

Also;

 * there's no need to add a [buildroot] in the title of your patches

 * your patches should have a different version each you post them. Use
   --subject-prefix="PATCHv2" with git format-patch or git send-email.

 * your patches should come with a cover letter that contains a
   changelog of the changes. See
   http://buildroot.org/downloads/manual/manual.html#submitting-patches.

Thanks!

Thomas

On Mon, 19 May 2014 09:28:56 +0000, Steve Thomas wrote:
> isl is a library for manipulating sets and relations of integer points
> bounded by linear constraints.
> 
> isl is needed for the optional graphite optimisations that are supported
> by gcc since version 4.5. Therefore this package is required for the
> toolchain to support graphite.
> 
> Graphite optimisations primarily involve loop blocking flattening and
> interchage so are probably of mimimal use in an embedded system where
> small sizes are favoured.
> 
> Signed-off-by: Steve Thomas <scjthm at live.com>
> ---
>  package/Config.in                 |  1 +
>  package/isl/Config.in             |  7 +++++++
>  package/isl/isl-000-libtool.patch | 28 ++++++++++++++++++++++++++++
>  package/isl/isl.mk                | 17 +++++++++++++++++
>  4 files changed, 53 insertions(+)
>  create mode 100644 package/isl/Config.in
>  create mode 100644 package/isl/isl-000-libtool.patch
>  create mode 100644 package/isl/isl.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 07fd166..1248eeb 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -780,6 +780,7 @@ source "package/glibmm/Config.in"
>  source "package/gmp/Config.in"
>  source "package/gsl/Config.in"
>  source "package/gtest/Config.in"
> +source "package/isl/Config.in"
>  source "package/libargtable2/Config.in"
>  source "package/libatomic_ops/Config.in"
>  source "package/libbsd/Config.in"
> diff --git a/package/isl/Config.in b/package/isl/Config.in
> new file mode 100644
> index 0000000..bc2a3ef
> --- /dev/null
> +++ b/package/isl/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_ISL
> +	bool "isl"
> +	select BR2_PACKAGE_GMP
> +	help
> +	  Library for manipulating sets and relations of integer points bounded by linear constraints.
> +
> +	  http://freecode.com/projects/isl
> diff --git a/package/isl/isl-000-libtool.patch b/package/isl/isl-000-libtool.patch
> new file mode 100644
> index 0000000..319c45a
> --- /dev/null
> +++ b/package/isl/isl-000-libtool.patch
> @@ -0,0 +1,28 @@
> +--- a/ltmain.sh	2014-04-23 23:52:39.104640815 +0000
> ++++ b/ltmain.sh	2014-04-23 23:56:59.818000038 +0000
> +@@ -2583,8 +2583,8 @@
> + 	# was found and let the user know that the "--tag" command
> + 	# line option must be used.
> + 	if test -z "$tagname"; then
> +-	  func_echo "unable to infer tagged configuration"
> +-	  func_fatal_error "specify a tag with '--tag'"
> ++	  func_echo "defaulting to \`CC'"
> ++	  func_echo "if this is not correct, specify a tag with \`--tag'"
> + #	else
> + #	  func_verbose "using $tagname tagged configuration"
> + 	fi
> +@@ -4172,8 +4172,12 @@
> + 	  # At present, this check doesn't affect windows .dll's that
> + 	  # are installed into $libdir/../bin (currently, that works fine)
> + 	  # but it's something to keep an eye on.
> +-	  test "$inst_prefix_dir" = "$destdir" && \
> +-	    func_fatal_error "error: cannot install '$file' to a directory not ending in $libdir"
> ++	  #
> ++	 # This breaks install into our staging area.  -PB
> ++	 #
> ++	 # test "$inst_prefix_dir" = "$destdir" && \
> ++	 #   func_fatal_error "error: cannot install \`$file' to a directory not ending in $libdir"
> ++
> + 
> + 	  if test -n "$inst_prefix_dir"; then
> + 	    # Stick the inst_prefix_dir data into the link command.
> diff --git a/package/isl/isl.mk b/package/isl/isl.mk
> new file mode 100644
> index 0000000..f6a5184
> --- /dev/null
> +++ b/package/isl/isl.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# isl
> +#
> +################################################################################
> +
> +ISL_VERSION = 0.13
> +ISL_SITE = http://isl.gforge.inria.fr/
> +ISL_LICENSE = MIT
> +ISL_LICENSE_FILES = LICENSE
> +ISL_INSTALL_STAGING = YES
> +ISL_DEPENDENCIES = gmp
> +
> +ISL_LIBTOOL_PATCH = NO
> +
> +$(eval $(autotools-package))
> +$(eval $(host-autotools-package))



-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list