[Buildroot] [PATCH v8 21/28] xbmc: Add X.org/OpenGL support

Yann E. MORIN yann.morin.1998 at free.fr
Sun May 18 17:29:28 UTC 2014


Bernd, All,

On 2014-05-18 18:58 +0200, Bernd Kuhls spake thusly:
> "Yann E. MORIN" <yann.morin.1998 at free.fr> wrote in
> news:20140518162900.GA3631 at free.fr: 
> 
> > Something like:
> [...]
> > should do the trick.
> 
> Hi,
> 
> for further comments I posted my current patch here:
> http://pastebin.com/zv7jueLB (expires in one week).
> 
> Especially the last "depends on" block looks crude, but seems to work.

Yep, it looks too dense. I think we can factor it into:

    depends on BR2_arm || BR2_i386 || BR2_x86_64
    depends on HAS_LIBEGL && HAS_LIBGLES \
            || (BR2_i386 || BR2_x86_64) && HAS_LIBGL

So, it first ensures that it is only visible for ARM or x86 (the only
archs we currently support SBMC on.)

Then, it is available only for EGL+GLES or x86+GL, since EGL+GLES is
posible on ARM and x86 alike, but full GL is only possible on x86.

I think it is much cleaner to separate the architectures dependencies
from the GL dependencies.

Of course, this would probably not scale if we were to support it on
other archs (eg. PPC), but it will be time to revisit this if/when we
happen to add that support.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list