[Buildroot] [PATCH v8 21/28] xbmc: Add X.org/OpenGL support

[Bernd Kuhls]

Hi,

"Yann E. MORIN" <yann.morin.1998 at free.fr> wrote in
news:20140517205500.GL3459 at free.fr: 

>> -comment "xbmc requires an OpenGL ES and EGL backend"
>> -     depends on BR2_arm || BR2_i386 || BR2_x86_64
>> -     depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_PACKAGE_HAS_LIBGLES
>> +comment "xbmc needs an OpenGL backend"
>> +     depends on (!BR2_arm && (BR2_i386 || BR2_x86_64)) && \
>> +          !BR2_PACKAGE_HAS_LIBGL && !(BR2_PACKAGE_HAS_LIBEGL &&
>> BR2_PACKAGE_HAS_LIBGLES) +
>> +comment "xbmc needs EGL & GLES support"
> 
> Please keep the original comment. Besides, this change makes the two
> comments incoherent:
> 
>     comment "xbmc needs an OpenGL backend"
>     comment "xbmc needs EGL & GLES support"

as I already stated ARM depends on EGL/GLES so my plan was to display

comment "xbmc needs EGL & GLES support"

on ARM, so users know what to enable, and

comment "xbmc needs an OpenGL backend"

on BR2_i386 || BR2_x86_64 only, here EGL/GLES or GL are accepted by xbmc.

> Could you join dependencies so they fit on one or two lines, instead of
> one pre line?
> 
> Ditto the configure options.

Done.

>> +XBMC_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) $(shell
>> $(PKG_CONFIG_HOST_BINARY) --cflags egl)" \ +    
>> CXXFLAGS="$(TARGET_CXXFLAGS) $(shell $(PKG_CONFIG_HOST_BINARY) --cflags
>> egl)" 
> 
> He! This XBMC_CONF_ENV did not pre-exist, and did not seem to be needed.

For Gotham it fixes a build error, this section will be a preparatory patch 
in v9.

Regards, Bernd