[Buildroot] rsync forces configure step
Cédric Marie
cedric.marie at openmailbox.org
Mon Jun 30 09:07:21 UTC 2014
Le 2014-06-30 10:55, Fabio Porcedda a écrit :
> The problem is that the stamp file for rsync is being removed with the
> "<pkg>-rebuild" command, so i think that the right fix is:
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 54193d2..67821ec 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -569,9 +569,6 @@ $(1)-graph-depends: graph-depends-requirements
> $(1)-dirclean: $$($(2)_TARGET_DIRCLEAN)
>
> $(1)-clean-for-rebuild:
> -ifneq ($$($(2)_OVERRIDE_SRCDIR),)
> - rm -f $$($(2)_TARGET_RSYNC)
> -endif
> rm -f $$($(2)_TARGET_BUILD)
> rm -f $$($(2)_TARGET_INSTALL_STAGING)
> rm -f $$($(2)_TARGET_INSTALL_TARGET)
>
> The problem is not related to top-level parallel build, the problem
> was present even the previous release (2014.02), the problem was
> always existed sine the introduction of the "<pk>-rebuild" feature:
>
> http://git.buildroot.net/buildroot/commit/?id=4ed4e5016b741341059ed826416dad3291df0b2c
> Author: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Date: Thu Sep 29 21:57:39 2011 +0200
> package: add <pkg>-rebuild and <pkg>-reconfigure
>
> Thomas do you know why you removed the sync stamp file?
>
> BR
Sorry, but I believe that removing the rsync stamp file is necessary
when rebuilding.
When you modify your local source files, you want them to be
synchronized when rebuilding.
The regression is forcing the configure step, which was not present in
2014.02.
Regards,
--
Cédric
More information about the buildroot
mailing list