[Buildroot] [PATCH] openntpd: add SysV initscript and user

[Arnout Vandecappelle]

On 23/06/14 00:43, Gustavo Zacarias wrote:
> On 06/22/2014 07:37 PM, Yann E. MORIN wrote:
> 
>>>> Any reason why you name the user and group with a leading '_' ?
>>>
>>> Because the code says so, and it's not configurable.
>>> The group just to keep consistency.
>>
>> Ok, that should be noted as a comment above the user definition, I
>> guess.
> 
> Why?
> We don't document these details for systemd or other packages, why
> should we here?
> I think the _USERS variable is explicit enough as documentation.

 Also, it is explicit in the commit message. So I agree that the patch is OK as
is. Well, putting a comment wouldn't hurt of course.

 So anyway:

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>


 Regards,
 Arnout

> Regards.
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F