[Buildroot] [PATCH v2 1/3] Makefile: target-finalize: add TARGET_FINALIZE_HOOKS

Fabio Porcedda fabio.porcedda at gmail.com
Mon Jun 23 09:22:54 UTC 2014


On Mon, Jun 23, 2014 at 11:20 AM, Arnout Vandecappelle <arnout at mind.be> wrote:
> On 23/06/14 11:14, Fabio Porcedda wrote:
>> On Sat, Jun 21, 2014 at 1:19 AM, Arnout Vandecappelle <arnout at mind.be> wrote:
>>> On 20/06/14 10:26, Fabio Porcedda wrote:
>>>> Add TARGET_FINALIZE_HOOKS to the "target-finalize" rule to be able to
>>>> add to it commands as needed.
>>>> This is useful for having a nicer output because commands are executed
>>>> after the "target-finalize" initial message, also it is useful to ensure
>>>> an executing order even when top-level parallel makefile is being used.
>>>
>>>  This commit message suggests that the patch would just add the call to the
>>> hooks, not actually changing the purge-locales implementation (which would be a
>>> separate patch).
>>>
>>>  For me, it doesn't have to a be a separate patch, but at least that additional
>>> change should be mentioned in the commit message.
>>
>> Ok, i will add at the end:
>>
>> Also convert "TARGET_PURGE_LOCALES" to a hook that use
>
>  uses
>
>
>  You can also add my
>
>     Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
>
> in that case.

Done, thanks.

BR
-- 
Fabio Porcedda


More information about the buildroot mailing list